fix: Improve brace handling in Cabal fields #4549
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved Brace Handling in Cabal Field Parsing
Overview
This PR enhances the Cabal plugin's ability to handle brace notation in
.cabal
files, addressing long-standing limitations in field parsing and completion. The changes improve support for real-world Cabal configurations that use braces for multi-line fields and complex dependencies.Technical Changes
Core Parser Improvements
Enhanced
findFieldSection
algorithm:\
)New
isBraceField
utility:Completion System Upgrades
pthread
,dl
)CoreFoundation
,CoreServices
)Testing Infrastructure
New Test Cases
frameworks: { CoreFoundation }
cc-options: {\n -Wall\n -Werror\n}
ld-options: {-framework { CoreServices }}
includes: dir/{header.h, other}
Test File Samples
Created
test/data/Cabal/brace-handling/
with:simple-braces.cabal
- Minimal brace casescomplex-multiline.cabal
- Real-world examplesedge-cases.cabal
- Challenging scenariosImpact Analysis
Future Work
Related Issues
Verification
All changes verified against: